[release-1.4] Fill response flag for stats plugin#2534
Merged
istio-testing merged 5 commits intoistio:release-1.4from Nov 7, 2019
Merged
[release-1.4] Fill response flag for stats plugin#2534istio-testing merged 5 commits intoistio:release-1.4from
istio-testing merged 5 commits intoistio:release-1.4from
Conversation
Contributor
|
@istio/release-managers-1-4 Any help on getting this in? |
howardjohn
approved these changes
Nov 7, 2019
Contributor
This is a known flake/issue that envoy keeps drained listener for up to 45s + frequent listener updates in the test. Retry.. |
Contributor
|
/test proxy-presubmit-tsan |
Contributor
|
I tuned drainage so that zombie listeners don't fail the test. This failure was due to TSAN violation that looks like the same one I filed in envoy today. |
Contributor
|
/test proxy-presubmit-tsan If it keeps failing, we may need to force skip it in TSAN. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2527