Skip to content

[release-1.4] Fill response flag for stats plugin#2534

Merged
istio-testing merged 5 commits intoistio:release-1.4from
istio-testing:cherry-pick-2527-to-release-1.4
Nov 7, 2019
Merged

[release-1.4] Fill response flag for stats plugin#2534
istio-testing merged 5 commits intoistio:release-1.4from
istio-testing:cherry-pick-2527-to-release-1.4

Conversation

@istio-testing
Copy link
Copy Markdown
Collaborator

This is an automated cherry-pick of #2527

@istio-testing istio-testing requested a review from a team November 7, 2019 18:58
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 7, 2019
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 7, 2019
@bianpengyuan
Copy link
Copy Markdown
Contributor

@istio/release-managers-1-4 Any help on getting this in?

@bianpengyuan
Copy link
Copy Markdown
Contributor

--- FAIL: TestStackdriverParallel (16.08s)
    stackdriver_xds_test.go:301: Get http://127.0.0.1:20183: net/http: request canceled (Client.Timeout exceeded while awaiting headers)
FAIL
FAIL	istio.io/proxy/test/envoye2e/stackdriver_plugin	75.415s
?   	istio.io/proxy/test/envoye2e/stackdriver_plugin/fake_stackdriver	[no test files]
ok  	istio.io/proxy/test/envoye2e/tcp_metadata_exchange	4.052s
Makefile.core.mk:77: recipe for target 'test_tsan' failed

This is a known flake/issue that envoy keeps drained listener for up to 45s + frequent listener updates in the test. Retry..

@bianpengyuan
Copy link
Copy Markdown
Contributor

/test proxy-presubmit-tsan

@kyessenov
Copy link
Copy Markdown
Contributor

I tuned drainage so that zombie listeners don't fail the test. This failure was due to TSAN violation that looks like the same one I filed in envoy today.

@kyessenov
Copy link
Copy Markdown
Contributor

/test proxy-presubmit-tsan

If it keeps failing, we may need to force skip it in TSAN.

@istio-testing istio-testing merged commit 8413e1d into istio:release-1.4 Nov 7, 2019
@istio-testing istio-testing deleted the cherry-pick-2527-to-release-1.4 branch November 7, 2019 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants