feat(edges): add support for canonical service labels #2804
Merged
istio-testing merged 7 commits intoistio:masterfrom Apr 21, 2020
Merged
feat(edges): add support for canonical service labels #2804istio-testing merged 7 commits intoistio:masterfrom
istio-testing merged 7 commits intoistio:masterfrom
Conversation
istio-testing
added
the
do-not-merge/work-in-progress
googlebot
added
the
cla: yes
istio-testing
added
size/M
douglas-reid
force-pushed
the
meshtelemetry-canonical-service
branch
from
729677d to
937f756
Compare
istio-testing
removed
the
needs-rebase
istio-testing
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
/test test_proxy |
Contributor
bianpengyuan
left a comment
bianpengyuan
left a comment
There was a problem hiding this comment.
Can we add the new field into integration test?
kyessenov
reviewed
Apr 20, 2020
istio-testing
added
size/L
Contributor
Author
Sorry, missed the file. Should be there now. |
kyessenov
reviewed
Apr 21, 2020
| FB_ASSIGN(source_canonical_revision, rev->value()); | ||
| } else { | ||
| instance[source_canonical_revision] = "latest"; | ||
| instance[source_canonical_revision] = ::Wasm::Common::kLatest.data(); |
Contributor
There was a problem hiding this comment.
This is expecting a string. Can you just pass a string view to avoid the scan? The compiler should auto convert from string_view to string.
Contributor
Author
There was a problem hiding this comment.
extensions/stats/plugin.cc:84:45: error: no viable overloaded '='
instance[source_canonical_revision] = ::Wasm::Common::kLatest;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~
/usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/basic_string.h:665:7: note: candidate function not viable: no known conversion from 'const absl::string_view' to 'const std::__cxx11::basic_string<char>' for 1st argument
operator=(const basic_string& __str)
^
/usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/basic_string.h:704:7: note: candidate function not viable: no known conversion from 'const absl::string_view' to 'const char *' for 1st argument
operator=(const _CharT* __s)
^
/usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/basic_string.h:715:7: note: candidate function not viable: no known conversion from 'const absl::string_view' to 'char' for 1st argument
operator=(_CharT __c)
^
/usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/basic_string.h:732:7: note: candidate function not viable: no known conversion from 'const absl::string_view' to 'std::__cxx11::basic_string<char>' for 1st argument
operator=(basic_string&& __str)
^
/usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/basic_string.h:795:7: note: candidate function not viable: no known conversion from 'const absl::string_view' to 'initializer_list<char>' for 1st argument
operator=(initializer_list<_CharT> __l)
Contributor
Author
There was a problem hiding this comment.
I'm beginning to have concerns about absl::string_view as it requires .data() calls when using with FlatBuffers (as far as I can tell).
From the docs:
Note that
string_view::data()may contain embedded nul
// characters, but the returned buffer may or may not be NUL-terminated;
// therefore, do not passdata()to a routine that expects a NUL-terminated
// string.
I think we should use char[] here.
Contributor
There was a problem hiding this comment.
Not a big deal. It'll get much cleaner with C++17.
Contributor
Author
There was a problem hiding this comment.
sorry, what do you think we need here to get this in?
kyessenov
approved these changes
Apr 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WorkloadInstancehas been updated to support the canonical service labels server-side.This PR updates the client definition and adds logic to populate that information. It will be used in Topology views related to canonical services.
As part of this PR, a few related consts are pulled out to a common location.