Add hooks for custom Istio Wasm extensions.#2916
Merged
istio-testing merged 6 commits intoistio:masterfrom Jul 17, 2020
Merged
Conversation
Signed-off-by: John Plevyak <jplevyak@gmail.com>
istio-testing
added
needs-rebase
googlebot
added
the
cla: yes
istio-testing
added
the
do-not-merge/work-in-progress
Contributor
Author
|
This is the companion to envoyproxy/envoy-wasm#576 |
Signed-off-by: John Plevyak <jplevyak@gmail.com>
istio-testing
removed
the
do-not-merge/work-in-progress
Signed-off-by: John Plevyak <jplevyak@gmail.com>
istio-testing
removed
the
needs-rebase
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
| namespace Wasm { | ||
| namespace Istio { | ||
|
|
||
| class IstioContext : public Context { |
Contributor
There was a problem hiding this comment.
Can you extract IstioContext to a separated context.h file? Extended ABI implemented in other files will need to include and reference this context.
Signed-off-by: John Plevyak <jplevyak@gmail.com>
bianpengyuan
approved these changes
Jul 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Plevyak jplevyak@gmail.com