Skip to content

Make extension doc generates snake case.#3191

Merged
istio-testing merged 1 commit intoistio:masterfrom
bianpengyuan:proxy-doc-gen/underscore
Feb 23, 2021
Merged

Make extension doc generates snake case.#3191
istio-testing merged 1 commit intoistio:masterfrom
bianpengyuan:proxy-doc-gen/underscore

Conversation

@bianpengyuan
Copy link
Copy Markdown
Contributor

Proxy extension is configured with snake case field name instead of camel case. Update doc gen to clarify it.

@bianpengyuan bianpengyuan requested review from a team February 12, 2021 18:56
@google-cla google-cla Bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 12, 2021
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 12, 2021
@ericvn
Copy link
Copy Markdown

ericvn commented Feb 12, 2021

Does this also need to be cherry-picked back to 1.9?

@bianpengyuan bianpengyuan added cherrypick/release-1.9 Set this label on a PR to auto-merge it to the release-1.9 branch cherrypick/release-1.8 Set this label on a PR to auto-merge it to the release-1.8 branch cherrypick/release-1.7 Set this label on a PR to auto-merge it to the release-1.7 branch labels Feb 12, 2021
@bianpengyuan
Copy link
Copy Markdown
Contributor Author

Yeah sure added several cherry-pick labels.

@bianpengyuan
Copy link
Copy Markdown
Contributor Author

@istio/wg-policies-and-telemetry-maintainers please take a look, thanks!

1 similar comment
@bianpengyuan
Copy link
Copy Markdown
Contributor Author

@istio/wg-policies-and-telemetry-maintainers please take a look, thanks!

Copy link
Copy Markdown
Contributor

@mandarjog mandarjog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@istio-testing istio-testing merged commit bb804d7 into istio:master Feb 23, 2021
@istio-testing
Copy link
Copy Markdown
Collaborator

In response to a cherrypick label: #3191 failed to apply on top of branch "release-1.7":

Applying: Make extension doc generates snake case.
Using index info to reconstruct a base tree...
M	Makefile.core.mk
M	extensions/attributegen/config.pb.html
M	extensions/stackdriver/config/v1alpha1/stackdriver_plugin_config.pb.html
M	extensions/stats/config.pb.html
Falling back to patching base and 3-way merge...
Auto-merging extensions/stats/config.pb.html
CONFLICT (content): Merge conflict in extensions/stats/config.pb.html
Auto-merging extensions/stackdriver/config/v1alpha1/stackdriver_plugin_config.pb.html
CONFLICT (content): Merge conflict in extensions/stackdriver/config/v1alpha1/stackdriver_plugin_config.pb.html
Auto-merging extensions/attributegen/config.pb.html
Auto-merging Makefile.core.mk
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Make extension doc generates snake case.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

@istio-testing
Copy link
Copy Markdown
Collaborator

In response to a cherrypick label: new issue could not be created for failed cherrypick: status code 410 not one of [201], body: {"message":"Issues are disabled for this repo","documentation_url":"https://docs.github.com/v3/issues/"}

@bianpengyuan
Copy link
Copy Markdown
Contributor Author

/cherrypick release-1.9

@istio-testing
Copy link
Copy Markdown
Collaborator

@bianpengyuan: new pull request created: #3206

Details

In response to this:

/cherrypick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherrypick/release-1.7 Set this label on a PR to auto-merge it to the release-1.7 branch cherrypick/release-1.8 Set this label on a PR to auto-merge it to the release-1.8 branch cherrypick/release-1.9 Set this label on a PR to auto-merge it to the release-1.9 branch cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants