build fixes#3801
Merged
istio-testing merged 3 commits intoistio:masterfrom Apr 9, 2022
Merged
Conversation
istio-testing
added
the
size/M
lambdai
approved these changes
Apr 6, 2022
Contributor
lambdai
left a comment
lambdai
left a comment
There was a problem hiding this comment.
This PR should have fixed the envoy binary build. Thank you!
Contributor
Author
|
Somehow abseil override is not picked up by wasm targets. Busting the cache and waiting 4 more hours for another build... |
Signed-off-by: Kuat Yessenov <kuat@google.com>
Contributor
Author
|
Failure in TCP stack driver extension. Need more debugging. |
Contributor
Author
|
Something is wrong with HTTP inspector, likely culprit is envoyproxy/envoy#17395. |
Signed-off-by: Kuat Yessenov <kuat@google.com>
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
|
Thanks. Looks like we know have an issue getting this into istio/istio: istio/istio#38310. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kuat Yessenov kuat@google.com
Still debugging wasm build issue.