Skip to content

Switch to envoyproxy/envoy. #4062

Merged
istio-testing merged 1 commit intoistio:experimental-ambientfrom
briansonnenberg:brians-use-upstream-envoy
Sep 15, 2022
Merged

Switch to envoyproxy/envoy. #4062
istio-testing merged 1 commit intoistio:experimental-ambientfrom
briansonnenberg:brians-use-upstream-envoy

Conversation

@briansonnenberg
Copy link
Copy Markdown

Includes necessary build-break fixes from main.

@briansonnenberg briansonnenberg requested a review from a team September 15, 2022 02:11
@istio-policy-bot
Copy link
Copy Markdown

😊 Welcome @briansonnenberg! This is either your first contribution to the Istio proxy repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 15, 2022
@istio-testing
Copy link
Copy Markdown
Collaborator

Hi @briansonnenberg. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn
Copy link
Copy Markdown
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Sep 15, 2022
@zirain
Copy link
Copy Markdown
Member

zirain commented Sep 15, 2022

what's the different with this PR #4058?

@kyessenov
Copy link
Copy Markdown
Contributor

Do we still need this branch?
We just merged ambient extensions into main.

@istio-testing istio-testing merged commit 63e5569 into istio:experimental-ambient Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants