Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/.commonfiles.sha
Original file line number Diff line number Diff line change
@@ -1 +1 @@
c2f65513cc37a8d42e699be6f09d5c09fe868325
2eb9688855b32f69186351bfef43fceb086125ac
2 changes: 1 addition & 1 deletion common/config/.golangci-format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

service:
# When updating this, also update the version stored in docker/build-tools/Dockerfile in the istio/tools repo.
golangci-lint-version: 1.38.x # use the fixed version to not introduce new linters unexpectedly
golangci-lint-version: 1.49.x # use the fixed version to not introduce new linters unexpectedly
run:
# timeout for analysis, e.g. 30s, 5m, default is 1m
deadline: 20m
Expand Down
6 changes: 2 additions & 4 deletions common/config/.golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

service:
# When updating this, also update the version stored in docker/build-tools/Dockerfile in the istio/tools repo.
golangci-lint-version: 1.38.x # use the fixed version to not introduce new linters unexpectedly
golangci-lint-version: 1.49.x # use the fixed version to not introduce new linters unexpectedly
run:
# timeout for analysis, e.g. 30s, 5m, default is 1m
deadline: 20m
Expand All @@ -34,7 +34,6 @@ run:
linters:
disable-all: true
enable:
- deadcode
- errcheck
- exportloopref
- gocritic
Expand All @@ -47,12 +46,11 @@ linters:
- lll
- misspell
- staticcheck
- structcheck
- stylecheck
- typecheck
- unconvert
- unparam
- varcheck
- unused
- gci
fast: false

Expand Down
2 changes: 1 addition & 1 deletion common/scripts/kind_provisioner.sh
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ function install_metallb() {

# Give this cluster of those IPs
RANGE="["
for i in {0..9}; do
for i in {0..19}; do
RANGE+="${METALLB_IPS4[1]},"
METALLB_IPS4=("${METALLB_IPS4[@]:1}")
if [[ "${#METALLB_IPS6[@]}" != 0 ]]; then
Expand Down