auto update extensions_build_config.bzl#4234
Conversation
kyessenov
left a comment
There was a problem hiding this comment.
@zirain What's the API for these extensions? I have no problem adding extensions that are used by Istio but I don't think EnvoyFilter is sustainable as an API. If users are de-facto relying on EnvoyFilter then we have to provide security fixes in the extensions you added. Are we comfortable providing support for all these extensions? I'd prefer if we opted-in the things we support rather than have the kitchen sink.
|
@zirain: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
the original thought is preventing manual sync this configuration with upstream, like istio/istio#42080 |
|
@zirain That doesn't happen that often. The cluster work was to reduce the binary size for envoy mobile, which is a one-time thing. I think that's a good question for TOC, whether we auto-import new extensions in Envoy into Istio. I'm mostly concerned about the support, some extensions are experimental and not very stable and may later be removed from Envoy. |
another question is why some extensions have a different name with upstream? if we do not want to support some extensions, we should add them to |
avoid issue like #4231
cc @kyessenov @lei-tang