Skip to content

Automator: update envoy@ in istio/proxy@master#4888

Closed
istio-testing wants to merge 1 commit into
istio:masterfrom
istio-testing:none-master-update_envoy_dep-1c4d1f14
Closed

Automator: update envoy@ in istio/proxy@master#4888
istio-testing wants to merge 1 commit into
istio:masterfrom
istio-testing:none-master-update_envoy_dep-1c4d1f14

Conversation

@istio-testing
Copy link
Copy Markdown
Collaborator

@istio-testing istio-testing commented Aug 10, 2023

Generated by Automator - 2023-08-16T18:58:06+00:00

@istio-testing istio-testing requested a review from a team August 10, 2023 18:54
@istio-testing istio-testing added the auto-merge Set this label on a PR to auto-merge it on success of presubmit tests label Aug 10, 2023
@istio-testing istio-testing force-pushed the none-master-update_envoy_dep-1c4d1f14 branch from 443605e to d278474 Compare August 10, 2023 18:54
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 10, 2023
@ericvn
Copy link
Copy Markdown

ericvn commented Aug 10, 2023

/retest

Although I suspect some upstream change is causing this and we need an update here.

@zirain
Copy link
Copy Markdown
Member

zirain commented Aug 11, 2023

I will take a look today.

@zirain
Copy link
Copy Markdown
Member

zirain commented Aug 11, 2023

/retest

@kyessenov
Copy link
Copy Markdown
Contributor

Could be envoyproxy/envoy#28517? Something is breaking emcc build.

@zirain
Copy link
Copy Markdown
Member

zirain commented Aug 11, 2023

Could be envoyproxy/envoy#28517? Something is breaking emcc build.

yes, looks like envoyproxy/envoy#28517 will fix, let's wait and see what will happen.

@ericvn
Copy link
Copy Markdown

ericvn commented Aug 11, 2023

envoyproxy/envoy#28517 is the latest commit that this PR is pointing to (at least right now) so it is included. So, as @kyessenov mentions, it could very well be the cause.

@kyessenov
Copy link
Copy Markdown
Contributor

We can merge #4891 and no longer care about emcc changes. Building wasm has nothing to do with envoy, so it's annoying that their builds are intertwined.

@istio-testing istio-testing force-pushed the none-master-update_envoy_dep-1c4d1f14 branch from d278474 to f20cb67 Compare August 11, 2023 18:55
@zirain
Copy link
Copy Markdown
Member

zirain commented Aug 12, 2023

/retest

@kyessenov
Copy link
Copy Markdown
Contributor

Looks like on ARM64 clang++ and clang need to be fully qualified paths.

@istio-testing istio-testing force-pushed the none-master-update_envoy_dep-1c4d1f14 branch 2 times, most recently from d1843a8 to ce1539a Compare August 13, 2023 18:55
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 13, 2023
@kyessenov
Copy link
Copy Markdown
Contributor

The third breaking change removal of implicit strings import, so it needs a code patch.

@istio-testing istio-testing force-pushed the none-master-update_envoy_dep-1c4d1f14 branch 2 times, most recently from b503466 to 12035f0 Compare August 15, 2023 18:56
@istio-testing istio-testing force-pushed the none-master-update_envoy_dep-1c4d1f14 branch from 12035f0 to befdc25 Compare August 16, 2023 18:58
@istio-testing
Copy link
Copy Markdown
Collaborator Author

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
release-test-arm64_proxy befdc25 link true /test release-test-arm64
test-arm-arm64_proxy befdc25 link true /test test-arm-arm64
test_proxy befdc25 link true /test test
test-asan_proxy befdc25 link true /test test-asan
test-tsan_proxy befdc25 link true /test test-tsan
release-test_proxy befdc25 link true /test release-test
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn
Copy link
Copy Markdown

ericvn commented Aug 16, 2023

Close this and let the next periodic update create again.

@ericvn ericvn closed this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Set this label on a PR to auto-merge it on success of presubmit tests size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants