Automator: update envoy@ in istio/proxy@master#4888
Conversation
443605e to
d278474
Compare
|
/retest Although I suspect some upstream change is causing this and we need an update here. |
|
I will take a look today. |
|
/retest |
|
Could be envoyproxy/envoy#28517? Something is breaking emcc build. |
yes, looks like envoyproxy/envoy#28517 will fix, let's wait and see what will happen. |
|
envoyproxy/envoy#28517 is the latest commit that this PR is pointing to (at least right now) so it is included. So, as @kyessenov mentions, it could very well be the cause. |
|
We can merge #4891 and no longer care about emcc changes. Building wasm has nothing to do with envoy, so it's annoying that their builds are intertwined. |
d278474 to
f20cb67
Compare
|
/retest |
|
Looks like on ARM64 clang++ and clang need to be fully qualified paths. |
d1843a8 to
ce1539a
Compare
|
The third breaking change removal of implicit strings import, so it needs a code patch. |
b503466 to
12035f0
Compare
12035f0 to
befdc25
Compare
|
@istio-testing: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Close this and let the next periodic update create again. |
Generated by Automator - 2023-08-16T18:58:06+00:00