Skip to content

Automator: update common-files@master in istio/proxy@master#5151

Merged
istio-testing merged 1 commit intoistio:masterfrom
istio-testing:master-master-commonfiles-17936691
Nov 18, 2023
Merged

Automator: update common-files@master in istio/proxy@master#5151
istio-testing merged 1 commit intoistio:masterfrom
istio-testing:master-master-commonfiles-17936691

Conversation

@istio-testing
Copy link
Copy Markdown
Collaborator

Generated by Automator - 2023-11-16T18:08:38+00:00

@istio-testing istio-testing requested a review from a team November 16, 2023 18:08
@istio-testing istio-testing added auto-merge Set this label on a PR to auto-merge it on success of presubmit tests release-notes-none Indicates a PR that does not require release notes. labels Nov 16, 2023
@istio-testing istio-testing force-pushed the master-master-commonfiles-17936691 branch from 76a4e6f to 870d264 Compare November 16, 2023 18:08
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 16, 2023
@ericvn
Copy link
Copy Markdown

ericvn commented Nov 16, 2023

/retest

@ericvn
Copy link
Copy Markdown

ericvn commented Nov 16, 2023

/test test

@ericvn
Copy link
Copy Markdown

ericvn commented Nov 16, 2023

/test test-asan

@ericvn
Copy link
Copy Markdown

ericvn commented Nov 17, 2023

/test test

@ericvn
Copy link
Copy Markdown

ericvn commented Nov 17, 2023

/test test-asan

@ericvn
Copy link
Copy Markdown

ericvn commented Nov 17, 2023

/test test

@zirain
Copy link
Copy Markdown
Member

zirain commented Nov 17, 2023

wait for #5150, which will skip tsan.

@ericvn
Copy link
Copy Markdown

ericvn commented Nov 17, 2023

/test test-asan

@zirain
Copy link
Copy Markdown
Member

zirain commented Nov 17, 2023

/retest

@ericvn
Copy link
Copy Markdown

ericvn commented Nov 17, 2023

/test test-asan

@zirain
Copy link
Copy Markdown
Member

zirain commented Nov 17, 2023

/test test

5 similar comments
@ericvn
Copy link
Copy Markdown

ericvn commented Nov 17, 2023

/test test

@ericvn
Copy link
Copy Markdown

ericvn commented Nov 17, 2023

/test test

@ericvn
Copy link
Copy Markdown

ericvn commented Nov 17, 2023

/test test

@ericvn
Copy link
Copy Markdown

ericvn commented Nov 17, 2023

/test test

@ericvn
Copy link
Copy Markdown

ericvn commented Nov 17, 2023

/test test

@ericvn
Copy link
Copy Markdown

ericvn commented Nov 17, 2023

/test test

It has passed once.

@ericvn
Copy link
Copy Markdown

ericvn commented Nov 17, 2023

/test test

@kyessenov
Copy link
Copy Markdown
Contributor

We're hitting an assertion error.

@kyessenov
Copy link
Copy Markdown
Contributor

assertion-failure.log

@kyessenov
Copy link
Copy Markdown
Contributor

I found the root cause and have a fix. Let's wait for upstream to address it before disabling tests.

@ericvn
Copy link
Copy Markdown

ericvn commented Nov 18, 2023

/test test

@istio-testing istio-testing merged commit a084a4b into istio:master Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Set this label on a PR to auto-merge it on success of presubmit tests release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants