Skip to content

Update envoy sha to incorporate ability to override server span name …#594

Closed
objectiser wants to merge 2 commits intoistio:masterfrom
objectiser:updateenvoy
Closed

Update envoy sha to incorporate ability to override server span name …#594
objectiser wants to merge 2 commits intoistio:masterfrom
objectiser:updateenvoy

Conversation

@objectiser
Copy link
Copy Markdown
Contributor

@objectiser objectiser commented Oct 19, 2017

…using one supplied from decorated client span

@objectiser
Update envoy sha to incorporate ability to override server span name …
e747583 
…using one supplied from decorated client span
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 19, 2017
@objectiser objectiser mentioned this pull request Oct 19, 2017
Merged
@rshriram
Copy link
Copy Markdown
Member

rshriram commented Oct 19, 2017 •
edited
Loading

Thanks! while you are at this, can you update to latest master SHA from envoy? I also have a PR that allows variable length cluster names in the stats. (e366bcf is the SHA) and (envoyproxy/envoy#1871 is the PR)

@rshriram
Copy link
Copy Markdown
Member

rshriram commented Oct 19, 2017

Oh never mind.. its already at the tip. Thanks for the update

@rshriram
Copy link
Copy Markdown
Member

rshriram commented Oct 19, 2017

/ok-to-test

@googlebot
Copy link
Copy Markdown
Collaborator

googlebot commented Oct 23, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. labels Oct 23, 2017
@rshriram
Copy link
Copy Markdown
Member

rshriram commented Oct 23, 2017

Closing.. Superseded by #600

@rshriram rshriram closed this Oct 23, 2017
@objectiser objectiser deleted the updateenvoy branch June 29, 2018 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@objectiser @rshriram @googlebot