Skip to content

update x-network header key #6790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
istio-testing merged 1 commit into from
Jan 27, 2026
Merged

update x-network header key #6790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/extensions/filters/http/peer_metadata/filter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ using ::Envoy::Extensions::Filters::Common::Expr::CelStateType;
struct HeaderValues {
const Http::LowerCaseString ExchangeMetadataHeader{"x-envoy-peer-metadata"};
const Http::LowerCaseString ExchangeMetadataHeaderId{"x-envoy-peer-metadata-id"};
const Http::LowerCaseString ExchangeMetadataOriginNetwork{"x-istio-origin-network"};
Copy link
Copy Markdown
Member

@zirain zirain Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we keep istio here?

Copy link
Copy Markdown
Contributor

@keithmattix keithmattix Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talking with @ilrudie, I don't think it's actually necessary since we're only using this in the hbone tunnel (vs. things like envoy-peer-metadata that are inserted into the user's http request). We're also using the x- prefix so there's no spec we're violating

const Http::LowerCaseString ExchangeMetadataOriginNetwork{"x-forwarded-network"};
};

using Headers = ConstSingleton<HeaderValues>;
Expand Down