Feature/v4 certify#293
Open
steven-schattenberg-itential wants to merge 13 commits intoitential:feature/v4from
Open
Feature/v4 certify#293steven-schattenberg-itential wants to merge 13 commits intoitential:feature/v4from
steven-schattenberg-itential wants to merge 13 commits intoitential:feature/v4from
Conversation
kvelarde-itential
requested changes
Jan 30, 2026
Contributor
kvelarde-itential
left a comment
There was a problem hiding this comment.
I think there are still some playbook/role structure issues. Let's discuss on a call.
Contributor
There was a problem hiding this comment.
As part of the integration with the new redis role, I think we will want to split this file into a certify-redis.yml and certify-sentinel.yml since redis and sentinel may run on different hosts.
Contributor
Author
There was a problem hiding this comment.
Agreed. I'd like to get this first iteration merged and then circle back and break out sentinel into its own certify and verify. I still have to merge the v4 redis changes anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds:
This change also replaces the old
preflightrole and removes those files.