Service Account auth from saved credentials; Fix and run tests on Travis.#11
Conversation
|
looks good! did you manage to run tests that are included in the library? can we fix/add a test for this? |
|
@shcheklein some tests are failing, will look into it |
maxhora
changed the title
|
@Maxris looks like a bunch of png1, png2 files were committed, do we need them? |
these 2 files - "a.png" and "b.png" are expected by tests to be in place, but it seems we can replace them with any dynamically generate pair of different(between each other) files. |
maxhora
force-pushed
the
service-account-keyless-auth
branch
2 times, most recently
from
4a61d4b to
d13ff2e
Compare
|
@efiop @shcheklein formatting checks are added in separate commit, should be good to merge all together |
|
@Maxris could we please revert the formatting? It's impossible now to review anything. We can apply it later. That why I wanted to make it as a separate step. We have way too many things at once in this PR now. |
|
@Maxris @shcheklein Sorry for the confusion, guys 🙁 |
@shcheklein I can revert last commit, no problem, but idea was that all source code changes not related to the formatting cheks are only in the first commit bcb5e2b which you can review and add comments by above link. |
|
@Maxris ah, okay, I see. Will it be easy for you to support this structure going forward? Up to you. |
|
@shcheklein I supposed only minor further changes to the codebase in scope of this PR and make 3rd commit with them :) But if there will be a lot things to change, then better to revert formatting check commit :) |
|
@Maxris sure, let me review the commit then and we can decide after that :) |
Suor
left a comment
Suor
left a comment
There was a problem hiding this comment.
I would say this ran out of scope, we should try to not make that even less unmanageable, i.e. finish the core and merge. Other ideas might be applied later.
|
going to backup code formatting changes in remote branch |
maxhora
force-pushed
the
service-account-keyless-auth
branch
from
d13ff2e to
b63ab7f
Compare
|
@shcheklein @Suor could you please check if it looks good now, thanks |
4 participants
No description provided.