file.GetContentFile: stream to disk, add callback#30
Merged
Conversation
- fixes #28 - related #20 - reference: https://developers.google.com/drive/api/v2/manage-downloads
3 tasks
7 tasks
shcheklein
reviewed
May 3, 2020
Contributor
Author
|
https://travis-ci.com/github/iterative/PyDrive2/builds/163561690 fails because a test expects the BOM to be stripped even when there's an implicit |
casperdcl
commented
May 3, 2020
casperdcl
commented
May 3, 2020
shcheklein
reviewed
May 3, 2020
shcheklein
reviewed
May 3, 2020
shcheklein
reviewed
May 3, 2020
shcheklein
reviewed
May 3, 2020
casperdcl
commented
May 5, 2020
shcheklein
reviewed
May 5, 2020
| # Initialize args for backward compatibility | ||
| super().__init__(http_error) | ||
|
|
||
| def GetField(self, field): |
Member
There was a problem hiding this comment.
we can simplify DVC code after release probably
Contributor
Author
There was a problem hiding this comment.
yes, on my post-merge list :)
Member
|
Looks good! Fixing the tests sounds good to me. |
shcheklein
approved these changes
May 5, 2020
Member
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
Looks cool! 😎 Let's fix the test and release the new version. We can simplify DVC a bit after this release.
casperdcl
added a commit
to casperdcl/dvc
that referenced
this pull request
May 5, 2020
efiop
pushed a commit
to treeverse/dvc
that referenced
this pull request
May 6, 2020
* wip * gdrive: add progress Part of #2865 See #2865 (comment) * gdrive: move towards next pydrive2 release - depends on iterative/PyDrive2#30 * update to latest pydrive>=1.4.11 * avoid unneeded API call * progress: gdrive: ensure proper bar_format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetContentFiletemporarily keeping the whole file in RAMcallbackfor external progress monitoringremove_bom=False. May be a breaking change to modify this test?)And the (
pydrive2) docstrings did say:And again, it (
httplib2) said:And the devs did shudder. There was wailing in the North and South. There was gnashing of teeth in the East and West.
And then one brave dev, in a quavering voice, spake thusly: