Conversation
…their detail modals
… email wording to Quote sent
…f not defined, add product type if not defined
…ient_id in Client Portal
…ted recurring payments, related saved cards and client payment provider relation
…les for that client
…is assigned a ticket
… selected, dont show relations in ticket edit if no client assigned to ticket, also dont display public and email response type if no contact_email exists
…Deprecated php-imap extension
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| // Enable crypto on the stream | ||
| if (!stream_socket_enable_crypto($fp, true, STREAM_CRYPTO_METHOD_TLS_CLIENT)) { |
Check failure
Code scanning / SonarCloud
Weak SSL/TLS protocols should not be used High
Comment on lines
+297
to
+306
| $sql_tags_filter = mysqli_query($mysqli, " | ||
| SELECT tag_id, tag_name | ||
| FROM tags | ||
| LEFT JOIN asset_tags ON asset_tag_tag_id = tag_id | ||
| LEFT JOIN assets ON asset_tag_asset_id = asset_id | ||
| WHERE tag_type = 5 | ||
| $client_query OR tag_id IN ($tag_filter) | ||
| GROUP BY tag_id | ||
| HAVING COUNT(asset_tag_asset_id) > 0 OR tag_id IN ($tag_filter) | ||
| "); |
Check failure
Code scanning / SonarCloud
Database queries should not be vulnerable to injection attacks High
Collaborator
|
Security alerts are false positives. |
wrongecho
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Develop into Master for v25.11.1 release