Ignore spaces after items in "Needs:" and "Tags:" lists#373
Conversation
|
@kaklakariada, thank you for reviewing my PR. But it's been stuck for over a day now waiting for the SonarCloud analysis, and I suspect that it's never going to complete. Do you know how to get that step to run? Also, I think this is a great project, so I thought I'd try addressing a few open issues as a way of showing my appreciation. So let me know if there's anything I should do to improve the quality of my PRs. I plan to open one PR per issue. Thanks. |
|
Hi @sambishop , - name: Sonar analysis
shell: bash
if: ${{ env.DEFAULT_OS == matrix.os && env.DEFAULT_JAVA == matrix.java && env.SONAR_TOKEN != null }}
run: |
mvn --batch-mode org.sonarsource.scanner.maven:sonar-maven-plugin:sonar \
-Dsonar.token=$SONAR_TOKEN
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}I guess the pragmatic solution would be to merge the PR anyway after a review. Another thing: I would like to add an entry to the changelog for your changes. I will do that directly in your PR if that's OK for you. |
|
I added tests and found a bug with parsing the |
…de to 'return !(...);'. (It was flagged by Sonar as a code smell.)
|
I've never used Sonar on a public repo before. I've tried adding a Sonar token secret to my forked repo, to see if that allows it to run. And I've addressed the only two outstanding Sonar issues. Let's see what happens. Thanks again for your help, @kaklakariada! |
redcatbear
left a comment
redcatbear
left a comment
There was a problem hiding this comment.
Looks really good! Thanks for the PR.
Couple small improvements suggested.
| # Changes | ||
|
|
||
| * [3.7.2](changes_3.7.2.md) | ||
| * [3.7.1](changes_3.7.1.md) |
There was a problem hiding this comment.
Last released version is 3.7.0. @kaklakariada, do you plan an intermediate release? If not, please move changes into 3.7.1.
There was a problem hiding this comment.
OFT 3.7.1 was released to Maven Central (https://repo1.maven.org/maven2/org/itsallcode/openfasttrace/openfasttrace-core/3.7.1/) and GitHub (https://github.com/itsallcode/openfasttrace/releases/tag/3.7.1), so the next release should be 3.7.2.
| + ").*?"), | ||
| ID("`?((?:" + SpecificationItemId.ID_PATTERN + ")|(?:" + SpecificationItemId.LEGACY_ID_PATTERN + "))`?.*"), | ||
| NEEDS_INT("Needs:\\s*(\\w+(?:,\\s*\\w+)*)"), | ||
| NEEDS_INT("Needs:(\\s*\\w+\\s*(?:,\\s*\\w+\\s*)*)"), |
| + "\nNeeds: " + NEEDS_ARTIFACT_TYPE1 // | ||
| + " , " + NEEDS_ARTIFACT_TYPE2 + " "; |
| private List<SpecificationItem> runImporterOnText(final String text) | ||
| { | ||
| final BufferedReader reader = new BufferedReader(new StringReader(text)); | ||
| final InputFile file = StreamInput.forReader(Paths.get(FILENAME), reader); |
There was a problem hiding this comment.
No intermediate file on the file system. I like it.
3 participants
Closes #364
This PR addresses issue 364: #364
I noticed that "Tags" lists behave the same way, so I updated them as well.