add modern javascript extension support#442
Merged
Merged
Conversation
Collaborator
|
Thanks a lot for the PR, always good to have developers from different backgrounds add missing coverage. Could you please also mention the newly supported file types in the handbook? |
Collaborator
|
Also, please add an entry to the change log for the next release. |
Contributor
Author
|
Requested changes have been added |
redcatbear
approved these changes
Apr 11, 2025
Collaborator
|
@leithouse, thank you very much for your PR and sorry for my late response. I am pretty busy at the moment. |
Contributor
Author
|
I know how it goes. Thanks for incorporating, will make our lives a bit easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to
.js, modern javascript may use.mjs,.cjs, and.ejs. This request adds those extensions toTagImporterFactory.javaandTestTagImporterFactory.javaNode Doc