Skip to content

Add output GitHub#1

Merged
liubin merged 3 commits intomasterfrom
7-case-output-github
May 18, 2015
Merged

Add output GitHub#1
liubin merged 3 commits intomasterfrom
7-case-output-github

Conversation

@liubin
Copy link
Contributor

@liubin liubin commented May 18, 2015

  • 含有数字7时显示GitHub

已经实现。求审查。

@liubin
Copy link
Contributor Author

liubin commented May 18, 2015

没有关于本次实现的测试代码,请添加一份。

@liubin
Copy link
Contributor Author

liubin commented May 18, 2015

@liubin 感谢您的审查。

关于功能方面有个问题。
比如,在本次实现之前,数字75应该显示fizzbuzz。
但在本次实现后,由于属于“含有数字7”的犯愁,会显示成GitHub。
您有没有想过让他显示成fizzbuzzGitHub这种复合形式呢?

@liubin
Copy link
Contributor Author

liubin commented May 18, 2015

原来如此,我没有想到这种情况。
请按照以下规范实现。

  • 即便是3或者5的倍数,只要含有数字7就显示GitHub

@liubin
Copy link
Contributor Author

liubin commented May 18, 2015

测试代码已经添加,新功能也已经实现。
审查后如无问题请进行合并。

liubin added a commit that referenced this pull request May 18, 2015
@liubin liubin merged commit a290343 into master May 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant