Removed slash ('/') at the end of URL for python 3.8 compatibility#20
Open
lepri wants to merge 1 commit intoiugu:masterfrom
Open
Removed slash ('/') at the end of URL for python 3.8 compatibility#20lepri wants to merge 1 commit intoiugu:masterfrom
lepri wants to merge 1 commit intoiugu:masterfrom
Conversation
When we're using Python 3.8 we get a duplicated path when URL ends with '/'. i.e.: 'https://api.iugu.com/v1/customers/customers'
Author
>>> url = 'https://api.iugu.com/v1/'
>>> path = 'customers'
>>> re.sub(r'/?$', re.sub(r'^/?', '/', str(path)), url)
'https://api.iugu.com/v1/customers/customers' |
Author
|
Hi, Anyone can take a look at this PR? |
thamiriszalko
approved these changes
Oct 14, 2020
thamiriszalko
left a comment
thamiriszalko
left a comment
There was a problem hiding this comment.
It works for me too! It's working locally.
|
This will not be merged? This company is a joke. |
diegoleft
approved these changes
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we're using Python 3.8 we get a duplicated path when URL ends with '/'.
i.e.: 'https://api.iugu.com/v1/customers/customers'