Shorten PyReduce FITS header keywords longer than 8 characters #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I don't think I will merge this one, exactly for the compatibility reasons that you mention. |
Contributor
Author
|
If it helps, I've changed it such that it can still read files with the old keywords, but new files get produced with the shortened keywords? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To conform with the FITS standard (max 8 chars) and get rid of repeated warnings in the log, I propose to shorten the following FITS keywords inserted by PyReduce:
It might be desirable to add some sort of backward compatibility with previously reduced files, but it will also complicate the code, perhaps unnecessarily.