Add fixes for hvc1#2
Open
emkman99 wants to merge 3 commits intoj-baker:jbaker/hvc1from
Open
Conversation
|
Could you fix mp4copy.rs in this PR? You can use this hvc1 video if you need to test it: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Fixed stsd
write_box()to include hvc1.-hev1 and hvc1 are the same except for the
completenessflag for parameter sets.-Also skip unknown boxes in hev1. None of my sample files have this, but we might as well keep hev1/hvc1 as similar as possible.
This works with all of my sample hvc1 and hev1 files.