set / get docblock is broken

[maboiteaspam]

        /**
         * Setter method, allows $model->set('property', 'value') access to data.
         *
         * @param  string|array $property
         * @param  string|null  $value
         * @return void
         */
        public function set($property, $value = null) {
            $this->orm->set($property, $value);
            return $this;
        }

        /**
         * Setter method, allows $model->set_expr('property', 'value') access to data.
         *
         * @param  string|array $property
         * @param  string|null  $value
         * @return void
         */
        public function set_expr($property, $value = null) {
            $this->orm->set_expr($property, $value);
            return $this;
        }

void instead of Model.

[tag]

Yes, Model is the correct return type for set_expr().

However, I'm not convinced set() should return Model, as you've done in the PR #99 (changing not just the docblock but the actual return value as well), even at the expense of chaining. This is because __set(), which naturally has a return type of void, calls set().

If it were to return anything other than void, set() should return the $value (which is which in practice is mixed, although the docblock indicates string|null).

[tag]

Heh. Although now that I've said the above, I see the develop branch has already modified set() to permit chaining. See #94.

[treffynnon]

Closed with the merge of #99.