Skip to content

Fix divide by 0 in shadow utils for some scenes #2209 #2210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scenemax3d merged 1 commit into from
Mar 2, 2024
Merged

Fix divide by 0 in shadow utils for some scenes #2209 #2210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions jme3-core/src/main/java/com/jme3/shadow/ShadowUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,8 +569,10 @@ public static void updateShadowCamera(ViewPort viewPort,
float scaleX, scaleY, scaleZ;
float offsetX, offsetY, offsetZ;

scaleX = (2.0f) / (cropMax.x - cropMin.x);
scaleY = (2.0f) / (cropMax.y - cropMin.y);
float deltaCropX = cropMax.x - cropMin.x;
float deltaCropY = cropMax.y - cropMin.y;
scaleX = deltaCropX == 0 ? 0 : 2.0f / deltaCropX;
scaleY = deltaCropY == 0 ? 0 : 2.0f / deltaCropY;

//Shadow map stabilization approximation from shaderX 7
//from Practical Cascaded Shadow maps adapted to PSSM
Expand All @@ -595,7 +597,8 @@ public static void updateShadowCamera(ViewPort viewPort,
offsetY = FastMath.ceil(offsetY * halfTextureSize) / halfTextureSize;
}

scaleZ = 1.0f / (cropMax.z - cropMin.z);
float deltaCropZ = cropMax.z - cropMin.z;
scaleZ = deltaCropZ == 0 ? 0 : 1.0f / deltaCropZ;
offsetZ = -cropMin.z * scaleZ;


Expand Down