Skip to content

Conversation

@jacalata
Copy link
Owner

@jacalata jacalata commented Jan 10, 2025

  • use 3.12 as target
  • have action workflows target 3.9 - 3.13

Summary by Sourcery

Update Python versions to 3.9-3.13 and set the target version to 3.12.

Build:

  • Update Python target version to 3.12.

CI:

  • Update CI workflows to use Python 3.9, 3.10, 3.11, 3.12, and 3.13.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 10, 2025

Reviewer's Guide by Sourcery

This pull request updates the target Python versions for the project to 3.12 and updates the GitHub action workflows to target versions 3.9 through 3.13.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated target Python version
  • Updated target-version in pyproject.toml to include 3.12.
pyproject.toml
Updated required Python version
  • Updated requires-python to 3.9.
pyproject.toml
Added Python 3.12 and 3.13 classifiers
  • Added classifiers for Python 3.12 and 3.13.
pyproject.toml
Updated Python versions in GitHub Actions workflows
  • Updated Python versions used in all GitHub Actions workflows to include 3.9, 3.10, 3.11, 3.12, and 3.13.
.github/workflows/check-coverage.yml
.github/workflows/generate-metadata.yml
.github/workflows/package.yml
.github/workflows/publish-pypi.yml
.github/workflows/python-app.yml
.github/workflows/run-e2-tests.yml
.github/workflows/run-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jacalata - I've reviewed your changes - here's some feedback:

Overall Comments:

  • There's a duplicate 'py312' in the black target-version list that should be removed
  • Please document the rationale for removing the dependencies (doit, ftfy, pytest-order) in the PR description. Consider splitting dependency removals into a separate PR for better change tracking
  • The PR description should explain the motivation for dropping Python 3.7/3.8 support and adding 3.13 testing
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

fix missing apostrophes, versions for black
ok fine the AI reviewer was right
@github-actions
Copy link

github-actions bot commented Jan 10, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
tabcmd
   __main__.py101010 0%
   tabcmd.py141414 0%
   version.py633 50%
tabcmd/commands
   commands.py101010 0%
   constants.py771515 81%
   server.py1302020 85%
tabcmd/commands/auth
   session.py3604242 88%
tabcmd/commands/datasources_and_workbooks
   datasources_and_workbooks_command.py1271616 87%
   datasources_workbooks_views_url_parser.py1401010 93%
   delete_command.py601616 73%
   export_command.py1142525 78%
   get_url_command.py1274747 63%
   publish_command.py872424 72%
   runschedule_command.py2177 67%
tabcmd/commands/extracts
   create_extracts_command.py4288 81%
   decrypt_extracts_command.py2722 93%
   delete_extracts_command.py3766 84%
   encrypt_extracts_command.py2722 93%
   extracts.py2022 90%
   reencrypt_extracts_command.py2722 93%
   refresh_extracts_command.py491313 73%
tabcmd/commands/group
   create_group_command.py2955 83%
   delete_group_command.py2722 93%
tabcmd/commands/project
   create_project_command.py4688 83%
   delete_project_command.py3544 89%
   publish_samples_command.py3044 87%
tabcmd/commands/site
   create_site_command.py3455 85%
   delete_site_command.py2822 93%
   edit_site_command.py3822 95%
   list_command.py441010 77%
   list_sites_command.py2922 93%
tabcmd/commands/user
   create_site_users.py571010 82%
   create_users_command.py601010 83%
   delete_site_users_command.py4355 88%
   user_data.py2213131 86%
tabcmd/execution
   _version.py222 0%
   global_options.py1462323 84%
   localize.py691111 84%
   logger_config.py4266 86%
   tabcmd_controller.py4277 83%
TOTAL271244384% 

@jacalata jacalata changed the base branch from development to main January 10, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants