-
Notifications
You must be signed in to change notification settings - Fork 0
Update python versions #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- re-use the _export_x methods instead of writing out the arguments multiple times - add specification of the project for CRUD calls - add a test for filtering a view on export
Reviewer's Guide by SourceryThis pull request updates the target Python versions for the project to 3.12 and updates the GitHub action workflows to target versions 3.9 through 3.13. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jacalata - I've reviewed your changes - here's some feedback:
Overall Comments:
- There's a duplicate 'py312' in the black target-version list that should be removed
- Please document the rationale for removing the dependencies (doit, ftfy, pytest-order) in the PR description. Consider splitting dependency removals into a separate PR for better change tracking
- The PR description should explain the motivation for dropping Python 3.7/3.8 support and adding 3.13 testing
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
fix missing apostrophes, versions for black
ok fine the AI reviewer was right
Summary by Sourcery
Update Python versions to 3.9-3.13 and set the target version to 3.12.
Build:
CI: