Skip to content

Fix require tidying for sneaky imports #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackfirth merged 1 commit into from
Nov 20, 2024
Merged

Fix require tidying for sneaky imports #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion default-recommendations/require-and-provide-suggestions-test.rkt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,17 @@ test: "require tidying of only non-phase spec forms should do nothing"
----------------------------------------


test: "require tidying shouldn't trigger when require transformers are imported and used"
test: "require tidying shouldn't trigger when transformers are imported and used"
----------------------------------------
(require racket/require
(multi-in racket (list set dict))
racket/hash)
----------------------------------------


test: "require tidying shouldn't trigger when transformers are imported and used in nested specs"
----------------------------------------
(require racket/require
(prefix-in racket: (multi-in racket (list set dict)))
racket/hash)
----------------------------------------
38 changes: 15 additions & 23 deletions default-recommendations/require-and-provide-suggestions.rkt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,35 +91,21 @@
except-in
prefix-in
rename-in
combine-in
relative-in
only-meta-in
only-space-in
for-syntax
for-template
for-label
for-meta)
(pattern mod:collection-module-path #:attr parsed (parsed-simple-import 0 'plain 'collection #'mod))
(pattern mod:file-module-path #:attr parsed (parsed-simple-import 0 'plain 'file #'mod))
(pattern ((~or only-in
except-in
prefix-in
rename-in
combine-in
relative-in
only-meta-in
only-space-in)
subspec ...)

(pattern :simple-module-import-spec)

(pattern (~or (only-in _:simple-module-import-spec _ ...)
(except-in _:simple-module-import-spec _ ...)
(prefix-in _ _:simple-module-import-spec)
(rename-in _:simple-module-import-spec _ ...))
#:cut
#:attr parsed (parsed-simple-import 0 'plain 'other-known this-syntax))

(pattern ((~and form
(~not only-in)
(~not except-in)
(~not prefix-in)
(~not rename-in)
(~not combine-in)
(~not relative-in)
(~not only-meta-in)
(~not only-space-in)
(~not for-syntax)
(~not for-template)
(~not for-label)
Expand All @@ -128,6 +114,12 @@
#:attr parsed (parsed-simple-import 0 'plain 'other-unknown this-syntax)))


(define-syntax-class simple-module-import-spec
#:attributes (parsed)
(pattern mod:collection-module-path #:attr parsed (parsed-simple-import 0 'plain 'collection #'mod))
(pattern mod:file-module-path #:attr parsed (parsed-simple-import 0 'plain 'file #'mod)))


(define-syntax-class collection-module-path
(pattern :id))

Expand Down
Loading