add fuse mount subtype to mountconfig #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
gluster example,kernel:myvolume on /mnt/gluster type fuse.glusterfs (rw,relatime,user_id=0,group_id=0,default_permissions,allow_other,max_read=131072) |
jacobsa
reviewed
Nov 1, 2017
mount_config.go
Outdated
| // documentation for this package. | ||
| Options map[string]string | ||
|
|
||
| SubType string |
Owner
There was a problem hiding this comment.
Please add documentation. Something like:
// The subtype to report for the file system, reflected in e.g. mount(8), which will report the type as "fuse.<subtype>".
mount_config.go
Outdated
| // documentation for this package. | ||
| Options map[string]string | ||
|
|
||
| SubType string |
Contributor
Author
There was a problem hiding this comment.
What do you mean about 'name this Subytpe'?
jacobsa
requested changes
Nov 2, 2017
Owner
jacobsa
left a comment
jacobsa
left a comment
There was a problem hiding this comment.
I mean please name the field "Subtype", not "SubType".
mount_config.go
Outdated
| // Sets the filesystem type (third field in /etc/mtab). /etc/mtab and | ||
| // /proc/mounts will show the filesystem type as fuse.SubType. | ||
| // If not set ,/proc/mounts will show the filesystem type as fuse/fuseblk | ||
|
|
Owner
There was a problem hiding this comment.
This empty line shouldn't be here.
Contributor
Author
There was a problem hiding this comment.
Thank your review. I will modify those.
mount_config.go
Outdated
|
|
||
| // Sets the filesystem type (third field in /etc/mtab). /etc/mtab and | ||
| // /proc/mounts will show the filesystem type as fuse.SubType. | ||
| // If not set ,/proc/mounts will show the filesystem type as fuse/fuseblk |
mount_config.go
Outdated
|
|
||
| // Sets the filesystem type (third field in /etc/mtab). /etc/mtab and | ||
| // /proc/mounts will show the filesystem type as fuse.SubType. | ||
| // If not set ,/proc/mounts will show the filesystem type as fuse/fuseblk |
Owner
There was a problem hiding this comment.
Full stop (".") after fuse/fuseblk.
inevity
force-pushed
the
mountsubtype
branch
3 times, most recently
from
cd9af56 to
eba79bc
Compare
Contributor
Author
|
Have amended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when want to mount jacobsa based filesystem,
we can use command like " mount -t goofys -o allow_other,debug http://cs6:6081:newbucket9 /mnt/s3
"
when mounted,the cmd mount will be "http://127.0.0.1:8080:goofys-test-terrrr on /mnt/s3 type fuse (rw,nosuid,nodev,relatime,user_id=0,group_id=0,default_permissions)
"
If not set subtype value by filesystem goofys,the output will be that the type is fuse.
If set subtype value as goofys by filesystem goofys. the output will be "http://127.0.0.1:8080:goofys-test-terrrr on /mnt/s3 type fuse.goofys (rw,nosuid,nodev,relatime,user_id=0,group_id=0,default_permissions)"