Add 'as loaded' sort ordering #976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaedb
requested changes
Nov 16, 2024
src/js/locale/en.yaml
Outdated
| more: 'All playlists (%{count})' | ||
| tracks: | ||
| title: Tracks | ||
| asloaded: 'As loaded' |
Owner
There was a problem hiding this comment.
Don't need to create a new translation entry here, duplication of fields.filters.as_loaded
src/js/views/Search.js
Outdated
| { value: 'followers', label: i18n('common.popularity') }, | ||
| { value: 'artist', label: i18n('common.artist') }, | ||
| { value: 'duration', label: i18n('common.duration') }, | ||
| { value: 'asloaded', label: i18n('search.asloaded')} |
Owner
There was a problem hiding this comment.
Have a gander at the equivalent syntax for other views, for instance src/js/views/Library/Albums.jsx.
"As loaded" translates quite literally to "don't sort me!" ie sortOrder: null:
{
value: null,
label: i18n('fields.filters.as_loaded'),
}
Contributor
Author
There was a problem hiding this comment.
Yes, that seems like a better way to do it!
src/js/components/SearchResults.js
Outdated
| (type === 'tracks' && sortField === 'followers' ? 'popularity' : sortField), | ||
| sortReverse, | ||
| ); | ||
| if (sortField !== 'asloaded') { |
Owner
There was a problem hiding this comment.
"As loaded" is null, so we would invert the logic here to if (sortField) { ... then sort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented 'as loaded' search by quite simply not sorting the results.
Resolves #933
I have only tested this with a single source of Spotify, so might be an good idea to test with multiple different sources to make sure it works before merging.