Skip to content
This repository was archived by the owner on Jul 1, 2022. It is now read-only.
This repository was archived by the owner on Jul 1, 2022. It is now read-only.

JaegerSpan::setTag no longer supports null values in version 1.7.0 #823

@amirhadadi

Description

@amirhadadi

JaegerSpan::setTag supported null values until version 1.7.0.
This change in JaegerSpan changed the tags map implementation from HashMap to ConcurrentHashMap which doesn't support null values.

To Reproduce
Steps to reproduce the behavior:
Call JaegerSpan::setTag with a null value. No exception until 1.7.0, but you get NPE with 1.7.0.

Expected behavior
No NPE when calling JaegerSpan::setTag with a null value.

Version (please complete the following information):

  • Jaeger version: 1.7.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions