This repository was archived by the owner on Jul 1, 2022. It is now read-only.
TRACER-#369: Added a logger property logr which will handle the excep… #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion in getTracer()
Author
|
retest this please @jpkrohling |
Contributor
|
@IamMujuziMoses Thank you for creating this PR - however unfortunately it does not address the problem that was outlined in the issue #369. If you could revisit that issue to understand the specific problem the issue author has raised, and then update the PR accordingly. |
Member
|
I would suggest looking at UdpSender and logging the exception directly there. Do not change loggers or levels in this PR. |
Contributor
I took your word and actually had a look at UdpSender: #726 |
Contributor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tion in getTracer()
Resolves #369