This repository was archived by the owner on Jul 1, 2022. It is now read-only.
Supports jaeger-debug-id in TraceContextCodec #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #701 +/- ##
============================================
- Coverage 89.57% 89.55% -0.03%
- Complexity 587 588 +1
============================================
Files 70 70
Lines 2159 2164 +5
Branches 282 284 +2
============================================
+ Hits 1934 1938 +4
Misses 136 136
- Partials 89 90 +1
Continue to review full report at Codecov.
|
pavolloffay
reviewed
Mar 24, 2020
jaeger-core/src/main/java/io/jaegertracing/internal/JaegerSpanContext.java
Outdated
Show resolved
Hide resolved
yurishkuro
reviewed
Mar 24, 2020
jaeger-core/src/main/java/io/jaegertracing/internal/propagation/TraceContextCodec.java
Outdated
Show resolved
Hide resolved
yurishkuro
reviewed
Mar 24, 2020
jaeger-core/src/test/java/io/jaegertracing/internal/propagation/TraceContextCodecTest.java
Outdated
Show resolved
Hide resolved
yurishkuro
reviewed
Mar 24, 2020
| try { | ||
| verify(System.out).write(captor.capture()); | ||
| verify(System.out, atLeast(0)).write(captor.capture(), anyInt(), anyInt()); | ||
| // gradle will call write(byte[]) instead of write(byte[],off,len) |
Member
There was a problem hiding this comment.
What does "gradle" have to do with unit test?
Contributor
Author
There was a problem hiding this comment.
gradle output log via write(byte[]) and eclipse output log via write(byte[],int,int) , before this change, tests failed with eclipse junit runner. I know this is fragile, but I cannot find a better way to assert log message.
yurishkuro
reviewed
Mar 24, 2020
jaeger-core/src/test/java/io/jaegertracing/internal/propagation/TraceContextCodecTest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
ping |
yurishkuro
reviewed
Apr 26, 2020
jaeger-core/src/main/java/io/jaegertracing/internal/JaegerSpanContext.java
Outdated
Show resolved
Hide resolved
yurishkuro
reviewed
Apr 26, 2020
jaeger-core/src/test/java/io/jaegertracing/internal/propagation/TraceContextCodecTest.java
Outdated
Show resolved
Hide resolved
yurishkuro
reviewed
Apr 26, 2020
jaeger-core/src/test/java/io/jaegertracing/internal/propagation/TraceContextCodecTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
yurishkuro
approved these changes
Apr 27, 2020
Member
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #699