Skip to content
This repository was archived by the owner on Jul 1, 2022. It is now read-only.

Conversation

@zhalas
Copy link
Contributor

@zhalas zhalas commented Mar 30, 2020

Which problem is this PR solving?

Short description of the changes

  • add publication and signing configuration for jaeger-thrift shadow artifact (this is currently not published as the current configuration only publishes components.java + sources + javadocs)

Testing performed

  • ./gradlew publishToMavenLocal -PskipSigning=true and verified that the shadow artifact is deployed to local maven repository
  • ./gradlew publishToMavenLocal and observed that :jaeger-thrift:signShadowPublication fails (it's not a full test, but should be good enough)

Signed-off-by: Zbigniew Halas <zbigniew@sumologic.com>
@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #704 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #704      +/-   ##
============================================
+ Coverage     89.57%   89.76%   +0.18%     
- Complexity      587      588       +1     
============================================
  Files            70       70              
  Lines          2159     2159              
  Branches        282      282              
============================================
+ Hits           1934     1938       +4     
+ Misses          136      132       -4     
  Partials         89       89              
Impacted Files Coverage Δ Complexity Δ
...ing/internal/samplers/RemoteControlledSampler.java 91.25% <0.00%> (-1.25%) 16.00% <0.00%> (-1.00%)
...gertracing/internal/reporters/LoggingReporter.java 90.90% <0.00%> (+9.09%) 5.00% <0.00%> (+1.00%)
...rtracing/internal/reporters/CompositeReporter.java 100.00% <0.00%> (+28.57%) 7.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b50aa15...9e7a319. Read the comment docs.

@yurishkuro
Copy link
Member

@pavolloffay you're more familiar with this setup, can you review?

@yurishkuro
Copy link
Member

@zhalas could you describe how you tested this? Unfortunately out CI will only test the release process when doing the actual release.

@zhalas
Copy link
Contributor Author

zhalas commented Jun 27, 2020

@yurishkuro I described my testing in Testing performed section in the PR description. The test was to publish to local Maven repository. I haven't fully tested the signing part (see the mentioned section), but if you want I can do that as well.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro merged commit 760fdda into jaegertracing:master Jun 27, 2020
@yurishkuro
Copy link
Member

@zhalas getting failures when publishing to Sonatype:

Invalid POM: /io/jaegertracing/jaeger-thrift/1.3.0/jaeger-thrift-1.3.0.pom: Project name missing, Project description missing, Project URL missing, License information missing, SCM URL missing, Developer information missing

#722

@zhalas
Copy link
Contributor Author

zhalas commented Jun 28, 2020

@yurishkuro I will look on Monday.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants