This repository was archived by the owner on Jul 1, 2022. It is now read-only.
Fix repeatedly error logging for HttpSender (#732) #785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix problem with repeatedly error logging when HttpSender is used. The problem was that removing "failed" command from 'commandFailedBefore' HashSet was always done when command execution ends successfully (i.e. without throwing SenderException). But there are some situations, when "span is only saved in a buffer" on sender level (or there is no any span to be sent) and remote communication is not started at all. Unfortunatelly the solution does not solve a problem if UdpSender is used. The reason is that PortUnreachableException is not thrown immediately, when DatagramSocket.send(DatagramPacket) method is invoked - this exception is thrown when subsequent call to send or receive is done. See Javadoc: - DatagramSocket.send(DatagramPacket) - DatagramSocket.connect(InetAddress, int) Signed-off-by: Radek Kraus <6397085+lenoch7@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #785 +/- ##
============================================
+ Coverage 89.03% 89.06% +0.02%
- Complexity 605 606 +1
============================================
Files 73 73
Lines 2261 2258 -3
Branches 295 295
============================================
- Hits 2013 2011 -2
Misses 157 157
+ Partials 91 90 -1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
HttpSenderis usedUdpSenderis used (see description)Short description of the changes
Resolves #732 - repeatedly error logging when
HttpSenderis used. The problem was that removing "failed" command fromcommandFailedBeforeHashSet was always done when command execution ends successfully (i.e. without throwingSenderException). But there are some situations, when "span is only saved in a buffer" on sender level (or there is no any span to be sent) and remote communication is not started at all.Unfortunately the solution does not solve a problem if
UdpSenderis used. The reason is thatPortUnreachableExceptionis not thrown immediately, whenDatagramSocket.send(DatagramPacket)method is invoked - this exception is thrown when subsequent call to send or receive is done. See Javadoc: