This repository was archived by the owner on Jul 1, 2022. It is now read-only.
Reduce locking in JaegerSpan #795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking at profiling results from some of our services, we see lock contention in JaegerSpan methods. This change reduces locking in JaegerSpan. It also removes Collections.unmodifiableXXX wrappers around copied collections. Signed-off-by: amirhadadi <amirhadadi@hotmail.com>
Signed-off-by: amirhadadi <amirhadadi@hotmail.com>
Codecov Report
@@ Coverage Diff @@
## master #795 +/- ##
============================================
- Coverage 89.01% 88.68% -0.34%
+ Complexity 605 604 -1
============================================
Files 73 73
Lines 2258 2245 -13
Branches 295 295
============================================
- Hits 2010 1991 -19
- Misses 157 161 +4
- Partials 91 93 +2
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Sep 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at profiling results from some of our services, we see lock contention in JaegerSpan methods.
This change reduces locking in JaegerSpan.
It also removes Collections.unmodifiableXXX wrappers around copied collections.
Resolves #792