update extract_into(), add example for bundles and add restart() method#147
Open
hacknus wants to merge 3 commits intojaemk:masterfrom
Open
update extract_into(), add example for bundles and add restart() method#147hacknus wants to merge 3 commits intojaemk:masterfrom
extract_into(), add example for bundles and add restart() method#147hacknus wants to merge 3 commits intojaemk:masterfrom
Conversation
Author
|
Can this be merged? |
Author
|
^bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #145.
I had to update the
extract_into()method such that it works for bundles/directories that are zipped.Additionally, I added an example in the
README.mdto describe the usage with bundles (specifically on macOS). For this example, we might consider putting thecopy_dir()also in this library, but for now I leave it like that.Furthermore, I included the
restart.rsfile with arestart()method that launches a zombie process of the own instance, allowing users to automatically restart the application afterself_replace()has been called.