Skip to content

feat(a11y): add aria-label tags #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jake8655 merged 1 commit into from
Jul 12, 2025
Merged

feat(a11y): add aria-label tags #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions src/components/footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,28 @@ export default function Footer() {
</div>

<div className="flex space-x-4">
<FooterEntry href="mailto:info@dominiktoth.com">
<FooterEntry
href="mailto:info@dominiktoth.com"
platformName="Email"
>
<Mail className="text-white" />
</FooterEntry>
<FooterEntry href="https://github.com/jake8655">
<FooterEntry
href="https://github.com/jake8655"
platformName="GitHub"
>
<SiGithub className="text-white" />
</FooterEntry>
<FooterEntry href="https://discord.com/users/300963276223807488">
<FooterEntry
href="https://discord.com/users/300963276223807488"
platformName="Discord"
>
<SiDiscord className="text-discord-blue" />
</FooterEntry>
<FooterEntry href="https://bsky.app/profile/dominiktoth.com">
<FooterEntry
href="https://bsky.app/profile/dominiktoth.com"
platformName="Bluesky"
>
<SiBluesky className="text-bluesky-blue" />
</FooterEntry>
</div>
Expand Down Expand Up @@ -63,9 +75,11 @@ export default function Footer() {

function FooterEntry({
href,
platformName,
children,
}: {
href: string;
platformName: string;
children: React.ReactNode;
}) {
return (
Expand All @@ -74,6 +88,7 @@ function FooterEntry({
target="_blank"
rel="noopener noreferrer"
className="flex gap-2 text-sm transition-transform hover:scale-110 md:text-base"
aria-label={`Contact Dominik Tóth via ${platformName}`}
>
{children}
</a>
Expand Down
1 change: 1 addition & 0 deletions src/components/locale-switcher.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ export default function LocaleSwitcher({ className }: { className?: string }) {
isPending && "transition-opacity [&:disabled]:opacity-30",
className,
)}
aria-label={t("label")}
>
<SelectValue placeholder={t("label")} />
</SelectTrigger>
Expand Down