feat: add orphaned-stages rule (v0.1.1)#6
Merged
Merged
Conversation
Adds a fifth lint rule that flags stages completely disconnected from the pipeline graph — no prerequisites and nothing depends on them. Violations are emitted at warning severity, rendering as [warn: orphaned-stages] in text output and "level": "warning" in SARIF. - Violation struct gains a Severity field (empty = error, "warning" = warn) - Reporter renders warn prefix in text; passes level through in SARIF - testdata/complex.json: 20-stage fixture exercising all five rules - CONTRIBUTING.md: contributor guide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orphaned-stagesas a fifth lint rule — flags stages that are completely disconnected from the pipeline graph (no prerequisites, nothing depends on them)[warn: orphaned-stages]in text output,"level": "warning"in SARIFViolationstruct gains aSeverityfield (""= error,"warning"= warn)testdata/complex.json: 20-stage fixture exercising all five rulesCONTRIBUTING.mdTest plan
make testpasses (22 tests, all green)TestOrphanedStages_ComplexTopologycovers diamond subgraph, separate chain, two orphaned islands, and empty-refId stage in one fixture[warn: orphaned-stages]prefix"level": "warning"for orphaned-stage violations