merge latest #1
Merged
merge latest #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By sharing the missing object across multiple calls to module.prefetch, and waiting until the next tick to call install.fetch, we can batch a rapid succession of module.prefetch calls into a single call to the install.fetch callback, potentially resulting in fewer HTTP requests.
This method was a Meteor-specific escape hatch for switching to native Node evaluation (e.g. for native .node modules) rather than evaluating bundled modules within the install.js module system. Starting with Meteor 1.6.2, Meteor will generate stub modules that call module.useNode() themselves, rather than relying on install.js to check whether module.useNode is defined and then call it. Not only is this a much cleaner separation of concerns, it also eliminates a small amount of performance overhead for every module evaluation, and it means we won't always switch to native Node evaluation just because we can, leaving room for bundled code to run instead.
Not only does this simplify the work of makeRequire (which is called just before every module begins evaluation), but it also removes the need for options.wrapRequire, since Module.prototype.require can be easily wrapped.
Remove unused options.
chore(package): update reify to version 0.17.2
* chore(package): update reify to version 0.18.1 Closes #51 * chore(package): update lockfile package-lock.json
Enable retrying dynamic imports after failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.