Pass captured transaction to ExecuteOnConnection callback instead of re-reading field

[Copilot]

Callers like WriteImageFile and PostUpdateProcessing were re-reading this.transaction inside their lambdas without holding transactionLock. When no active transaction exists, the lambda falls through to the unlocked path at line 90 — a concurrent BeginTransaction between the check and the callback could cause the lambda to execute against a mismatched connection/transaction pair.

Changes

• ExecuteOnConnection signature: Func<SqliteConnection, T> → Func<SqliteConnection, SqliteTransaction?, T>
• Inside lock: passes lock-captured currentTransaction directly to callback — func(currentTransaction.Connection, currentTransaction)
• No-transaction path: passes null — func(connection, null)
• Transactional callers (WriteImageFile, PostUpdateProcessing): updated to use the provided tx parameter instead of this.transaction
• Non-transactional callers: use (connection, _) discarding the parameter

// Before — re-reads this.transaction outside the lock
ExecuteOnConnection(connection => connection.Execute(sql, param, this.transaction));

// After — uses the lock-captured reference passed by ExecuteOnConnection
ExecuteOnConnection((connection, tx) => connection.Execute(sql, param, tx));

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[jamesmoore]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".