Conversation
…r-jhdf-build Add jitpack.yml to build with Java 17 and skip tests/checkstyle
Codex-generated pull request
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a1153065ec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (minBits == elementBytes * 8) { | ||
| System.arraycopy(encodedData, bufOffset, decoded, 0, outputSize); | ||
| if (needsByteSwap(dtypeOrder)) { | ||
| swapEndianInPlace(decoded, elementBytes); | ||
| } | ||
| return decoded; |
There was a problem hiding this comment.
The minBits == elementBytes * 8 fast path returns immediately before dtypeClass is checked, so float scale-offset chunks can bypass the explicit unsupported-float guard and be treated as already-decoded bytes. When a float chunk reports full-width minBits (which can happen on incompressible data), decode will silently return incorrect data instead of failing fast, making the corruption hard to detect.
Useful? React with 👍 / 👎.
1 participant
Fixing #511
Most implementation by codex after scaffolding