This repository was archived by the owner on Jun 15, 2019. It is now read-only.
Fix for rowSpan on first two columns causes extra cells on the right #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamestalmage will this PR be merged? |
Owner
|
Sorry for being unresponsive on this. Any chance I can get you to write a regression test for this? (one that fails with the old code, and passes with the new). |
Author
|
Thanks for getting back to this! I forgot all about how this works but I‘ll take a shot at it after Christmas. |
|
@realityking Thanks so much for the fix! I have the same bug in my project. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21
There might be a better way but this works 😄