This repository was archived by the owner on Jun 15, 2019. It is now read-only.
Docs and tests for header logic #53
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutantcornholio
added a commit
to mutantcornholio/DefinitelyTyped
that referenced
this pull request
Oct 27, 2018
Though it is not currently documented, `head` prop accepts `Cell[]`, not `string[]`. I've made PR to cli-table2 regarding this (jamestalmage/cli-table2#53), but typings should be fixed whether it is megred or not
mutantcornholio
added a commit
to mutantcornholio/DefinitelyTyped
that referenced
this pull request
Oct 27, 2018
Though it is not currently documented, `head` prop accepts `Cell[]`, not `string[]`. I've made PR to cli-table2 regarding this (jamestalmage/cli-table2#53), but typings should be fixed whether it is megred or not
mutantcornholio
added a commit
to mutantcornholio/DefinitelyTyped
that referenced
this pull request
Oct 27, 2018
Though it is not currently documented, `head` prop accepts `Cell[]`, not `string[]`. I've made PR to cli-table2 regarding this (jamestalmage/cli-table2#53), but typings should be fixed whether it is megred or not
mutantcornholio
added a commit
to mutantcornholio/DefinitelyTyped
that referenced
this pull request
Oct 27, 2018
Though it is not currently documented, `head` prop accepts `Cell[]`, not `string[]`. I've made PR to cli-table2 regarding this (jamestalmage/cli-table2#53), but typings should be fixed whether it is megred or not
mutantcornholio
added a commit
to mutantcornholio/DefinitelyTyped
that referenced
this pull request
Oct 27, 2018
Though it is not currently documented, `head` prop accepts `Cell[]`, not `string[]`. I've made PR to cli-table2 regarding this (jamestalmage/cli-table2#53), but typings should be fixed whether it is megred or not
mutantcornholio
added a commit
to mutantcornholio/DefinitelyTyped
that referenced
this pull request
Oct 27, 2018
Though it is not currently documented, `head` prop accepts `Cell[]`, not `string[]`. I've made PR to cli-table2 regarding this (jamestalmage/cli-table2#53), but typings should be fixed whether it is megred or not
mutantcornholio
added a commit
to mutantcornholio/DefinitelyTyped
that referenced
this pull request
Oct 27, 2018
Though it is not currently documented, `head` prop accepts `Cell[]`, not `string[]`. I've made PR to cli-table2 regarding this (jamestalmage/cli-table2#53), but typings should be fixed whether it is megred or not
mutantcornholio
added a commit
to mutantcornholio/DefinitelyTyped
that referenced
this pull request
Oct 27, 2018
Though it is not currently documented, `head` prop accepts `Cell[]`, not `string[]`. I've made PR to cli-table2 regarding this (jamestalmage/cli-table2#53), but typings should be fixed whether it is megred or not
mutantcornholio
added a commit
to mutantcornholio/DefinitelyTyped
that referenced
this pull request
Oct 27, 2018
Though it is not currently documented, `head` prop accepts `Cell[]`, not `string[]`. I've made PR to cli-table2 regarding this (jamestalmage/cli-table2#53), but typings should be fixed whether it is megred or not
mutantcornholio
added a commit
to mutantcornholio/DefinitelyTyped
that referenced
this pull request
Oct 27, 2018
Though it is not currently documented, `head` prop accepts `Cell[]`, not `string[]`. I've made PR to cli-table2 regarding this (jamestalmage/cli-table2#53), but typings should be fixed whether it is megred or not
9 tasks
It was undocumented that `head` can accept custom cells, not just strings. Couldn't find info about it both in docs and tests. So, I've added some docs and tests
mutantcornholio
force-pushed
the
docs-tests-for-headers
branch
2 times, most recently
from
41b8eb7 to
780ef66
Compare
Author
|
@jamestalmage ping? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
While I've been rewriting my app to TypeScript and I've discovered that
headtype inTableOptionsin DefinitelyTyped isstring[], while it actually acceptsCell[](this type).So, I was going to make fix there, but couldn't find that
headacceptsCell[]anywhere in docs or tests. So.. I've added some.I'd be glad if you'd pull this commit.