Fix bug in missing_some#22
Merged
jamsesso merged 1 commit intojamsesso:masterfrom Jan 5, 2022
Merged
Conversation
magnarn
force-pushed
the
magnarn/bugfix/missing-some
branch
from
59a4ba3 to
42d6df0
Compare
When missing_some is applied to a `null` data object, it would return all its arguments, including the threshold. According to the spec, it should return an array of the missing keys. Also, if the threshold is 0, it should always return an empty list, even when data is `null`.
magnarn
force-pushed
the
magnarn/bugfix/missing-some
branch
from
42d6df0 to
b7d7feb
Compare
Owner
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
missing_someis applied to anulldata object, it would returnall its arguments, including the threshold. According to the spec, it
should return an array of the missing keys.
Also, if the threshold is 0, it should always return an empty list,
even when data is
null.