Skip to content

Add validation for --serverpublicip #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pljones merged 1 commit into from
Feb 17, 2021
Merged

Add validation for --serverpublicip #1004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,9 +578,17 @@ int main ( int argc, char** argv )
qWarning() << "Mute my own signal in my personal mix is only supported in headless mode.";
}

if ( !strServerPublicIP.isEmpty() && ( strCentralServer.isEmpty() || bIsClient ) )
if ( !strServerPublicIP.isEmpty() )
{
qWarning() << "Server Public IP will only take effect when registering a server with a central server.";
QHostAddress InetAddr;
if ( !InetAddr.setAddress ( strServerPublicIP ) )
{
qWarning() << "Server Public IP is invalid. Only plain IP addresses are supported.";
}
if ( strCentralServer.isEmpty() || bIsClient )
{
qWarning() << "Server Public IP will only take effect when registering a server with a central server.";
}
}

// per definition: if we are in "GUI" server mode and no central server
Expand Down