Drop admin rights on open Jamulus after install#1006
Merged
ann0see merged 3 commits intojamulussoftware:masterfrom Feb 17, 2021
Merged
Drop admin rights on open Jamulus after install#1006ann0see merged 3 commits intojamulussoftware:masterfrom
ann0see merged 3 commits intojamulussoftware:masterfrom
Conversation
ann0see
requested review from
a team and
softins
and removed request for
a team
Member
Author
|
Sorry softins, I don't know why it automatically assigned you here. Probably the setting is still not 100% correct. |
pljones
approved these changes
Feb 17, 2021
Collaborator
pljones
left a comment
pljones
left a comment
There was a problem hiding this comment.
I'm going to assume you've tested all the scenarios for saving state. I've forgotten my NSIS syntax...
Member
Author
|
Yes, it’s almost the same code as the other checkbox and I did check it. If bugs occur, sure, we can solve them. |
softins
approved these changes
Feb 17, 2021
Member
softins
left a comment
softins
left a comment
There was a problem hiding this comment.
OK, I haven't the ability to test this, but it looks sensible, and I have read the original description of the technique.
Member
Author
|
It’s probably not the cleanest way to solve it, but it seems to work. I‘ll merge this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #995 with a workaround explained here: http://mdb-blog.blogspot.com/2013/01/nsis-lunch-program-as-user-from-uac.html
Fixes #860 (not the ASIO part, but that's probably a wontfix).