Skip to content

Server: Send empty channel list on connect #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hoffie merged 2 commits into from
Mar 2, 2021
Merged

Server: Send empty channel list on connect #1010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65adb71
Server: Send empty channel list on connect
hoffie Feb 17, 2021
9786099
Changelog: Document #955, #1009, #1010
hoffie Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@
- stop sending traffic to CloudFlare as part of the external IP detection
logic (#633, #1092), suggested by atsampson, coded by hoffie

- bug fix: properly restore mixer levels after reconnecting to a restarted
server. updating the server or the client is sufficient to fix this. coded
by hoffie (#955, #1009, #1010)



### 3.6.2 (2020-12-12) ###
Expand Down
5 changes: 5 additions & 0 deletions src/server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,6 +594,11 @@ void CServer::OnNewConnection ( int iChID,
// must be the first message to be sent for a new connection)
vecChannels[iChID].CreateClientIDMes ( iChID );

// Send an empty channel list in order to force clients to reset their
// audio mixer state. This is required to trigger clients to re-send their
// gain levels upon reconnecting after server restarts.
vecChannels[iChID].CreateConClientListMes ( CVector<CChannelInfo> (0) );

// query support for split messages in the client
vecChannels[iChID].CreateReqSplitMessSupportMes();

Expand Down