Update unit of measure display in settings dialog#1755
Closed
henkdegroot wants to merge 1 commit intojamulussoftware:masterfrom
Closed
Update unit of measure display in settings dialog#1755henkdegroot wants to merge 1 commit intojamulussoftware:masterfrom
henkdegroot wants to merge 1 commit intojamulussoftware:masterfrom
Conversation
pljones
reviewed
May 24, 2021
| if ( iPingTime > 500 ) | ||
| { | ||
| const QString sErrorText = "<font color=\"red\"><b>>500 ms</b></font>"; | ||
| const QString sErrorText = "<font color=\"red\"><b>>500</b></font>"; |
Collaborator
There was a problem hiding this comment.
Oops! :) I missed that...
pljones
approved these changes
May 24, 2021
jujudusud
approved these changes
May 24, 2021
hoffie
approved these changes
May 25, 2021
Member
hoffie
left a comment
hoffie
left a comment
There was a problem hiding this comment.
Thanks! Given that this PR avoids introducing a new bug compared to 3.7.0, I'd be inclined to merge for 3.8.0 and I'm tagging it as such.
Opinions?
Contributor
Author
Member
|
No. I don’t think so |
Collaborator
|
We can re-open if #1762 doesn't go ahead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit of measure in settings dialog now displayed always (regardless the client is connected or not) to remove update to "fixed" text.
Unit of measure removed from error text when exceeding 500ms.
Fixes #1753