CJamRecorder: Add currentSession pointer initialization and improve locking#1826
CJamRecorder: Add currentSession pointer initialization and improve locking#1826pljones merged 2 commits intojamulussoftware:masterfrom
Conversation
|
Thanks for opening this PR! @pljones should have a look at this code since he wrote most of it. |
ann0see
left a comment
There was a problem hiding this comment.
Jamulus uses an odd code style. You should apply clang format ;-).
hoffie
left a comment
There was a problem hiding this comment.
Thanks!
On a high level, this looks good to me. I'm leaving the more extensive reviews for @pljones and @softins though.
There's one formatting thing to fix (you can run clang-format on it if you have version 10 or later). I've just approved the workflows for this PR which will probably also show the relevant line.
softins
left a comment
There was a problem hiding this comment.
Looks fine to me, subject to the formatting adjustments that have already been mentioned. Thanks!
|
OK, will upload corrected file later - after running clang-format! Thanks to all for the helpful comments. |
|
CHANGELOG: Jam Recorder's internal locking and initiatlization code has been made more robust. |
|
Now running on my jam server. |
Server code tested on Windows and Ubuntu 20.04.