-
Notifications
You must be signed in to change notification settings - Fork 242
Add pull request template #1827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
3fcd0ed
c9d6f53
1a88b72
a2be693
7a91759
014ca93
64f6854
81e46b3
a800dae
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,28 @@ | ||||||
| <!-- Thank you for working on Jamulus and opening a Pull Request! Please fill the following to make the review process straight foward --> | ||||||
|
|
||||||
| **Short description of changes** | ||||||
|
|
||||||
| <!-- A short description of your changes which might go into the change log --> | ||||||
|
|
||||||
| **Context: Fixes an issue?** | ||||||
|
|
||||||
| <!-- If this fixes an issue, please write Fixes: <issue number here>; if not, please give your PR a context. --> | ||||||
|
|
||||||
| **Does this change need documentation? What needs to be documented and how?** | ||||||
|
|
||||||
| <!-- Most new features should be documented on the website: https://github.com/jamulussoftware/jamuluswebsite/ If you have a proposal what to document, feel free to open a draft PR on the website repo --> | ||||||
|
|
||||||
| **Status of this Pull Request** | ||||||
| <!-- This might be edited by maintainers. --> | ||||||
| <!-- Proof of concept (not to be merged soon); Working implementation; ... --> | ||||||
|
|
||||||
| **What is missing until this pull request can be merged?** | ||||||
| <!-- Does it still need more testing; ... --> | ||||||
|
|
||||||
| ## Checklist | ||||||
| <!-- Please tick the check boxes when done by replacing the space by an x, e.g. [x]. --> | ||||||
| - [ ] I've verified that this Pull Request follows the [general code principles](https://github.com/jamulussoftware/jamulus/blob/master/CONTRIBUTING.md#jamulus-projectsource-code-general-principles) | ||||||
| - [ ] I tested my code and it does what I want | ||||||
|
ann0see marked this conversation as resolved.
|
||||||
| - [ ] My code follows the [style guide](https://github.com/jamulussoftware/jamulus/blob/master/CONTRIBUTING.md#source-code-consistency) <!-- You can also check if your code passes clang-format --> | ||||||
| - [ ] I waited some time after this Pull Request was opened and all GitHub checks completed without errors. <!-- GitHub doesn't run these checks for new contributors automatically. --> | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This might add pressure. Pinging should not be too common in my opinion. |
||||||
| - [ ] I've filled all the content above | ||||||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @dcorson-ticino-com would this wording be ok? |
||||||
Uh oh!
There was an error while loading. Please reload this page.