i18n: add zh_CN translation by BLumia · Pull Request #1922 · jamulussoftware/jamulus

BLumia · 2021-07-19T16:12:02Z

Short description of changes

Add zh_CN translation

Context: Fixes an issue?

Not a bugfix patch.

Does this change need documentation? What needs to be documented and how?

No.

Status of this Pull Request

Most of the zh_CN translations are done, some of them still need to work but I suggest merge this patch first. I might still need some time to understand some of its features and some other translation strings may need to be changed (I'll open a new issue or PR for that once I'm ready)

What is missing until this pull request can be merged?

Waiting on second review; Add BLumia to translators in util file;

Checklist

I've verified that this Pull Request follows the general code principles
I tested my code and it does what I want
My code follows the style guide
I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
I've filled all the content above

ann0see · 2021-07-19T19:05:27Z

Hi, thank you! Adding new languages is always great! Finally a non European language ;-).

Tagging @softins here (he knows the translation process well). Be prepared to get some more information on the translation process soon.

ann0see · 2021-07-19T19:35:41Z

Actually, I think we don’t have a non technical translator onboarding for the app…

So just some quick notes here:

Usually we do a translation sprint before each new release. During normal development time, feel free to contribute translations, however strings might change. Once the release process is at a specific stage, we’ll freeze the GUI so that new translations are avoided if possible. After this point, translators can start their work
If you plan to contribute for a longer time, we‘ll add you to the jamulussoftware/translators GitHub role (not sure when someone is added/deleted, how much we rely on reputation etc. that‘s probably a team decision)
If you’re added to this group, you will also get access to a translators chat for exchange with other translators

Not sure if I missed something. I‘d suggest you to open a GitHub discussion if you plan to contribute more (=Tell the community that you’re a new translator). Maybe someone else can also help out with Chinese?

Just from a personal perspective: can you check if the GUI is OK after the translation? Non ASCII letters aren’t that common in the app yet.

BLumia · 2021-07-20T05:50:11Z

Usually we do a translation sprint before each new release. During normal development time, feel free to contribute translations, however strings might change. Once the release process is at a specific stage, we’ll freeze the GUI so that new translations are avoided if possible. After this point, translators can start their work.

Totally understand, and feel free to tag me when you need to update the zh_CN translation :)

If you plan to contribute for a longer time, we‘ll add you to the jamulussoftware/translators GitHub role

I'd love to, thanks.

I‘d suggest you to open a GitHub discussion if you plan to contribute more (=Tell the community that you’re a new translator). Maybe someone else can also help out with Chinese?

Will do that later.

Just from a personal perspective: can you check if the GUI is OK after the translation? Non ASCII letters aren’t that common in the app yet.

Yeah, it's okay. I got the program compiled on my Windows installation with my MSYS2/MinGW64 environment and it works fine :)

ann0see

Thanks! That seems like a lot of work. See my comments. They're not all addressed to you ;-).

ann0see · 2021-07-20T09:19:36Z

+    </message>
+    <message>
+        <location filename="../../util.cpp" line="392"/>
+        <source>There is a server which collects  the audio data from each client, mixes the audio data and sends the mix  back to each client.</source>


Issue in English: there's a space too much.

While working on the translation, I found there are also some other issues in the original translation strings, I will discuss them in separated issue or PR after this one get merged :)

Yes. Thanks. Would be great.

ann0see · 2021-07-20T09:20:45Z

+    <message>
+        <location filename="../../aboutdlgbase.ui" line="72"/>
+        <source>Copyright (C) 2005-2021 The Jamulus Development Team</source>
+        <translation>版权所有 (C) 2005-2021 Jamulus 开发团队</translation>


I think you don't need to translate Development Team, but that's fully up to you.

If the whole "The Jamulus Development Team" is a trademark or something, I think I would avoid translate Development Team as 开发团队, if not, I recommend to translate it :)

ann0see · 2021-07-20T09:22:16Z

+    </message>
+    <message>
+        <location filename="../../audiomixerboard.cpp" line="1112"/>
+        <source>Personal Mix at: </source>


This one should be translated before a merge since it's prominent on the mixing board.

ann0see · 2021-07-20T09:31:24Z

+    <message>
+        <source>List</source>
+        <translation type="vanished">列表</translation>
+    </message>


I think this (and all the other translations which have vanished) don't need a translation?

Yes, I actually did the translation by editing the italian ts file and generate qm file use the linguist application and then I realized Jamulus did embed the qm files to resource file instead distribute qm files inside the translation folder. Then I cloned the full source, added the ts and qm file that I already translated, then run lrelease and reworked some translation and compile it manually. The vanished strings are the ones I did translated before I get compile the program by myself.

ann0see · 2021-07-20T09:34:21Z

+    </message>
+    <message>
+        <location filename="../../util.h" line="618"/>
+        <source>Requirements not fulfilled</source>


Tagging @gilgongo here. I doubt this error message is user friendly... Should we open an issue on that?

Seems like we should re-write that. Wonder what it refers to?

Probably if the directory rejects the server to register with it?

jamulus/src/util.h

Line 586 in 27f9a35

SRS_NOT_FULFILL_REQUIREMENTS

ann0see

Thanks. Need to test/compile it locally on Debian before another review round ;-).

Before this can get merged, we need:

a proposal for the change log entry (Something like Translation: Added Chinese translation)
… to add you to the utils file
… another approving review

ann0see

Translator listed in the src/util.cpp optionally add link to PR or code
Looks consistent
Passes tools/check-wininstaller-translations.sh (No Chinese translation for installer)

softins · 2021-07-22T15:26:56Z

Tagging @softins here (he knows the translation process well). Be prepared to get some more information on the translation process soon.

Mainly that I wrote up the translation workflow for Github and Qt Linguist here. I expect @BLumia has already studied it. :)

softins · 2021-07-22T15:32:13Z

I got the program compiled on my Windows installation with my MSYS2/MinGW64 environment and it works fine :)

@BLumia, I'm interested in your compilation workflow with MSYS2/MinGW64. I used the MinGW environment for compiling on Windows about 8 years ago when contributing to MuseScore (which also uses Qt), but I haven't used it since then. Please could you send a few notes on it? Thanks!

softins

I have done a check for duplicated accelerator keys and found five instances, which I have flagged. Everything else looks fine (although I have no idea about the Chinese!)

BLumia · 2021-07-23T05:53:00Z

I'm interested in your compilation workflow with MSYS2/MinGW64. I used the MinGW environment for compiling on Windows about 8 years ago when contributing to MuseScore (which also uses Qt), but I haven't used it since then. Please could you send a few notes on it? Thanks!

With MSYS2 it's actually quite easy to compile it. I got mingw-w64-x86_64-qt5 (not the static one) and mingw-w64-x86_64-qt-creator installed and compile it just inside QtCreator, then I saw it says it's missing ASIO headers, then I downloaded ASIO SDK from here and placed them into windows\ASIOSDK2\, then it compiles without any other issue :)

MuseScore might need a lot of other build depts so it might be more complex than compile Jamulus, I haven't tried to compile MuseScore, though. BTW I use MSYS2 to compile a lot of my own stuff and I already got some other libs installed from MSYS2 repo while doing that, so I'm not sure if Jamulus need any additional depts other than Qt and ASIO SDK that I already installed before.

i18n: add zh_CN translation

a9be898

ann0see added this to the Release 3.8.1 milestone Jul 19, 2021

fix(i18n): correct translation for feedback detection feature

cee3113

ann0see reviewed Jul 20, 2021

View reviewed changes

Comment thread src/res/translation/translation_zh_CN.ts Outdated

ann0see reviewed Jul 20, 2021

View reviewed changes

fix: update translation according to PR code review

ea44fbd

BLumia requested a review from ann0see July 22, 2021 06:06

ann0see reviewed Jul 22, 2021

View reviewed changes

ann0see requested a review from softins July 22, 2021 06:49

ann0see approved these changes Jul 22, 2021

View reviewed changes

softins requested changes Jul 22, 2021

View reviewed changes

fix: correct accelerator keys

dbb25cb

BLumia requested a review from softins July 23, 2021 05:29

fix: the missed one

8a1d406

softins approved these changes Jul 24, 2021

View reviewed changes

softins merged commit 0838c56 into jamulussoftware:master Jul 24, 2021

BLumia deleted the i18n-zh-cn branch July 25, 2021 05:12

Conversation

BLumia commented Jul 19, 2021 • edited by ann0see Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

ann0see commented Jul 19, 2021

Uh oh!

ann0see commented Jul 19, 2021

Uh oh!

BLumia commented Jul 20, 2021

Uh oh!

Uh oh!

ann0see left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ann0see Jul 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ann0see left a comment

Choose a reason for hiding this comment

Uh oh!

ann0see left a comment

Choose a reason for hiding this comment

Uh oh!

softins commented Jul 22, 2021

Uh oh!

softins commented Jul 22, 2021

Uh oh!

softins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BLumia commented Jul 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

BLumia commented Jul 19, 2021 •

edited by ann0see

Loading

ann0see Jul 20, 2021 •

edited

Loading